fix(q): harden response handling and encode dict results - #5
Merged
singaraiona merged 3 commits intoSep 3, 2026
Merged
Conversation
belowzeroff
force-pushed
the
fix/q-response-message-type
branch
from
September 2, 2026 19:37
3ec6721 to
4cf7ce6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How it looks from the user's side
A q client asks a Rayforce Q-wire server for a native dictionary result:
Before -- the server failed to serialize the native
RAY_DICT, so the user saw a Q error instead of the dictionary:After -- the same expression round-trips as a Q dictionary:
A client asking real q for the identity value also now gets a Rayforce null instead of a decode error:
What changed
Fixes several Q IPC response edge cases:
q_exchange, so pushed or malformed frames are not mistaken for sync replies.RAY_DICTvalues as Q dictionaries on the wire.::, wire type 101 primitive 0) as Rayforce null.MSG_NOSIGNALon send, so closed peers fail as ordinary send errors instead of terminating the process.ray_errorvalues in decode/server cleanup paths.Tests
Covered: